diff options
authorjoevt <joevt@shaw.ca>2021-09-26 01:33:23 -0700
committerHans Verkuil <hverkuil-cisco@xs4all.nl>2021-09-27 12:53:56 +0200
commit91ba30e2bd413da416d424ce3c6ee735e24c6ec6 (patch)
parent9ec0f56dfc1546907fc408f548dc7987310c72ec (diff)
edid-decode: DisplayID non-0 filler fixes
It's probably not a Product Identification Data Block or any kind of block so data_block should be cleared (so that the block name doesn't appear in the Failures section for this fail). Output hex data because it might contain interesting data (it's at least known to be not zero). Signed-off-by: Joe van Tunen <joevt@shaw.ca> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
1 files changed, 3 insertions, 0 deletions
diff --git a/parse-displayid-block.cpp b/parse-displayid-block.cpp
index 5266bb3..dc2ec7b 100644
--- a/parse-displayid-block.cpp
+++ b/parse-displayid-block.cpp
@@ -1745,8 +1745,11 @@ unsigned edid_state::displayid_block(const unsigned version, const unsigned char
if (!tag && !len) {
// A Product Identification Data Block with no payload bytes is not valid - assume this is the end.
+ data_block.clear(); // Probably not a Product Identification Data Block so clear this.
if (!memchk(x, length)) {
+ printf(" Filler:\n");
fail("Non-0 filler bytes in the DisplayID block.\n");
+ hex_block(" ", x, length);
return length;

Privacy Policy