diff options
authorHans Verkuil <hverkuil@xs4all.nl>2019-01-11 12:37:03 +0100
committerHans Verkuil <hverkuil-cisco@xs4all.nl>2019-01-11 13:25:47 +0100
commit1e89980a8651f6cddbe20f4e02c958dbf2f33d08 (patch)
parentdc639011e00b8b5e2fc8c1ce270e9942601b02fa (diff)
vivid: do not implement VIDIOC_S_PARM for output streamsbr-buf_val
v4l2_compliance gave a warning for the S_PARM test for output streams: warn: v4l2-test-formats.cpp(1235): S_PARM is supported for buftype 2, but not for ENUM_FRAMEINTERVALS The reason is that vivid mapped s_parm for output streams to g_parm. But if S_PARM doesn't actually change anything, then it shouldn't be enabled at all. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/media/platform/vivid/vivid-core.c b/drivers/media/platform/vivid/vivid-core.c
index c931f007e5b0..7da5720b47a2 100644
--- a/drivers/media/platform/vivid/vivid-core.c
+++ b/drivers/media/platform/vivid/vivid-core.c
@@ -371,7 +371,7 @@ static int vidioc_s_parm(struct file *file, void *fh,
if (vdev->vfl_dir == VFL_DIR_RX)
return vivid_vid_cap_s_parm(file, fh, parm);
- return vivid_vid_out_g_parm(file, fh, parm);
+ return -ENOTTY;
static int vidioc_log_status(struct file *file, void *fh)

Privacy Policy