diff options
authorChanwoo Choi <cw00.choi@samsung.com>2017-10-23 10:32:07 +0900
committerMyungJoo Ham <myungjoo.ham@samsung.com>2017-10-26 17:08:40 +0900
commit1051e2c304b5cf17d4117505985f8128c5c64fd9 (patch)
parentab8f58ad72c4d1abe59216362ddb8bfa428c9071 (diff)
Revert "PM / devfreq: Add show_one macro to delete the duplicate code"
This reverts commit 3104fa3081126c9bda35793af5f335d0ee0d5818. The {min|max}_freq_show() show the stored value of the struct devfreq. But, if the drivers/thermal/devfreq_cooling.c disables the specific frequency value, {min|max}_freq_show() have to check this situation before showing the stored value. So, this patch revert the macro in order to add the additional codes. Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
1 files changed, 11 insertions, 9 deletions
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 6a6f88bccdee..b6ba24e5db0d 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -1124,6 +1124,12 @@ unlock:
return ret;
+static ssize_t min_freq_show(struct device *dev, struct device_attribute *attr,
+ char *buf)
+ return sprintf(buf, "%lu\n", to_devfreq(dev)->min_freq);
static ssize_t max_freq_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
@@ -1150,17 +1156,13 @@ unlock:
return ret;
+static DEVICE_ATTR_RW(min_freq);
-#define show_one(name) \
-static ssize_t name##_show \
-(struct device *dev, struct device_attribute *attr, char *buf) \
-{ \
- return sprintf(buf, "%lu\n", to_devfreq(dev)->name); \
+static ssize_t max_freq_show(struct device *dev, struct device_attribute *attr,
+ char *buf)
+ return sprintf(buf, "%lu\n", to_devfreq(dev)->max_freq);
-static DEVICE_ATTR_RW(min_freq);
static DEVICE_ATTR_RW(max_freq);
static ssize_t available_frequencies_show(struct device *d,

Privacy Policy