path: root/Documentation
diff options
authorBjorn Andersson <bjorn.andersson@linaro.org>2021-05-15 21:09:53 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-05-21 14:27:25 +0200
commit8c9b3caab3ac26db1da00b8117901640c55a69dd (patch)
treed600f11d9877baf7938a4b7aa9c039c7f86bb531 /Documentation
parentacf5631c239dfc53489f739c4ad47f490c5181ff (diff)
usb: typec: ucsi: Clear pending after acking connector change
It's possible that the interrupt handler for the UCSI driver signals a connector changes after the handler clears the PENDING bit, but before it has sent the acknowledge request. The result is that the handler is invoked yet again, to ack the same connector change. At least some versions of the Qualcomm UCSI firmware will not handle the second - "spurious" - acknowledgment gracefully. So make sure to not clear the pending flag until the change is acknowledged. Any connector changes coming in after the acknowledgment, that would have the pending flag incorrectly cleared, would afaict be covered by the subsequent connector status check. Fixes: 217504a05532 ("usb: typec: ucsi: Work around PPM losing change information") Cc: stable <stable@vger.kernel.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Acked-By: Benjamin Berg <bberg@redhat.com> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Link: https://lore.kernel.org/r/20210516040953.622409-1-bjorn.andersson@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions

Privacy Policy