path: root/drivers/ata
diff options
authorColin Ian King <colin.king@canonical.com>2017-10-16 12:00:11 +0100
committerTejun Heo <tj@kernel.org>2017-10-23 07:05:56 -0700
commit14d7045c7f3b0a9d3b00274c23d7d516fc6d44d9 (patch)
tree159c06b6c392485a80bf367f7757b016541328b6 /drivers/ata
parentb1314e3f85b36ce1311d7242085f6dd93709c694 (diff)
ata: sata_mv: remove a redundant assignment to pointer ehi
The pointer ehi is being assigned to a value that is never read and is redundant. Clean up the code and move the ehi declaration and initialization to the code block where it is used. Cleans up clang warning: Value stored to 'ehi' is never read Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'drivers/ata')
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index 3b2246dded74..dbb62b508213 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -2478,20 +2478,18 @@ static unsigned int mv_get_err_pmp_map(struct ata_port *ap)
static void mv_pmp_eh_prep(struct ata_port *ap, unsigned int pmp_map)
- struct ata_eh_info *ehi;
unsigned int pmp;
* Initialize EH info for PMPs which saw device errors
- ehi = &ap->link.eh_info;
for (pmp = 0; pmp_map != 0; pmp++) {
unsigned int this_pmp = (1 << pmp);
if (pmp_map & this_pmp) {
struct ata_link *link = &ap->pmp_link[pmp];
+ struct ata_eh_info *ehi = &link->eh_info;
pmp_map &= ~this_pmp;
- ehi = &link->eh_info;
ata_ehi_push_desc(ehi, "dev err");
ehi->err_mask |= AC_ERR_DEV;

Privacy Policy