aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/atm/lanai.c
diff options
context:
space:
mode:
authorSebastian Siewior <sebastian@breakpoint.cc>2009-02-16 11:28:15 +0000
committerDavid S. Miller <davem@davemloft.net>2009-02-18 17:37:09 -0800
commit57e8f26a10ac4af488292199bb0435555f6723f3 (patch)
tree8a2a8a0e8f68729ec7531b733f82d8b666e8a3aa /drivers/atm/lanai.c
parent82a5bd6a7b1b60b5d357e2e4b93b914f57314016 (diff)
net/mv643xx: don't disable the mib timer too early and lock properly
mib_counters_update() also restarts the timer. So the timer is dequeued, the stats are read and then the timer is enqueued again. This is "okay" unless someone unloads the module. The locking here is also broken: mib_counters_update() grabs just a simple spinlock. The only thing the lock is good for is to protect the timer func against other callers namely mv643xx_eth_stop() && mv643xx_eth_get_ethtool_stats(). That means if the spinlock is taken via the ethtool path and than the timer kicks in then the box will lock up. Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc> Acked-by: Lennert Buytenhek <buytenh@marvell.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/atm/lanai.c')
0 files changed, 0 insertions, 0 deletions

Privacy Policy