path: root/drivers/hid/hid-roccat.c
diff options
authorDan Carpenter <dan.carpenter@oracle.com>2016-04-02 07:44:32 +0300
committerJiri Kosina <jkosina@suse.cz>2016-04-04 09:49:12 +0200
commit85d08340c3de1126467db4e69140fe483d91c114 (patch)
tree8736e4301116f766974e7441a5d58d32c28f7785 /drivers/hid/hid-roccat.c
parentd66435cc7da95964cb386674bd82ec12ca66320a (diff)
HID: roccat: silence an uninitialized variable warning
My static checker complains because we use "dev_id" before we check for errors so it could be uninitialized. Fix this by moving the error handling forward a couple lines. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-roccat.c')
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/hid/hid-roccat.c b/drivers/hid/hid-roccat.c
index 65c4ccfcbd29..76d06cf87b2a 100644
--- a/drivers/hid/hid-roccat.c
+++ b/drivers/hid/hid-roccat.c
@@ -421,14 +421,13 @@ static int __init roccat_init(void)
retval = alloc_chrdev_region(&dev_id, ROCCAT_FIRST_MINOR,
- roccat_major = MAJOR(dev_id);
if (retval < 0) {
pr_warn("can't get major number\n");
goto error;
+ roccat_major = MAJOR(dev_id);
cdev_init(&roccat_cdev, &roccat_ops);
retval = cdev_add(&roccat_cdev, dev_id, ROCCAT_MAX_DEVICES);

Privacy Policy