path: root/drivers/hwmon
diff options
authorDan Carpenter <dan.carpenter@oracle.com>2017-10-24 12:47:42 +0300
committerGuenter Roeck <linux@roeck-us.net>2017-10-29 18:36:03 -0700
commit5813da157f7dbe03d268c8d0dd9425d0e3944910 (patch)
treef4b6901727e4c5bfcd6af64b9dd77e185667d00b /drivers/hwmon
parenta3bdc5b5bd369fcab8306b80d2c740e332183d20 (diff)
hwmon: (max6621) Inverted if condition in max6621_read()
We intended to test for failure here but accidentally tested for success. It means that we don't set "*val" to true and it means that if i2c_smbus_write_byte() does fail then we return success. Fixes: e7895864b0d7 ("hwmon: (max6621) Add support for Maxim MAX6621 temperature sensor") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Vadim Pasternak <vadimp@mellanox.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/max6621.c b/drivers/hwmon/max6621.c
index 22079ec29660..35555f0eefb9 100644
--- a/drivers/hwmon/max6621.c
+++ b/drivers/hwmon/max6621.c
@@ -296,7 +296,7 @@ max6621_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
if (regval) {
ret = i2c_smbus_write_byte(data->client,
- if (!ret)
+ if (ret)
return ret;

Privacy Policy