path: root/drivers/idle
diff options
authorAnna-Maria Gleixner <anna-maria@linutronix.de>2016-11-27 00:13:31 +0100
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>2016-12-01 23:01:36 +0100
commit29d7bbada98e0969dd2ea159104aa55052a1c439 (patch)
tree104af5d874c257382c97cb3c4d69fb90ef551132 /drivers/idle
parent4e28ec3d5fe0b994fe87b2406d75d9c351ef4940 (diff)
intel_idle: Remove superfluous SMP fuction call
Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu") the CPU_ONLINE and CPU_DOWN_PREPARE notifiers are always run on the hot plugged CPU, and as of commit 3b9d6da67e11 ("cpu/hotplug: Fix rollback during error-out in __cpu_disable()") the CPU_DOWN_FAILED notifier also runs on the hot plugged CPU. This patch converts the SMP functional calls into direct calls. smp_function_call_single() executes the function with interrupts disabled. This calling convention is not preserved, because tick_broadcast_enable() and tick_braodcast_disable() handle interrupts themselves. Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/idle')
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index d6377c16b3f8..3828babfb77b 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -971,8 +971,7 @@ static int cpu_hotplug_notify(struct notifier_block *n,
if (lapic_timer_reliable_states != LAPIC_TIMER_ALWAYS_RELIABLE)
- smp_call_function_single(hotcpu, __setup_broadcast_timer,
- (void *)true, 1);
+ __setup_broadcast_timer((void *)true);
* Some systems can hotplug a cpu at runtime after

Privacy Policy