aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/mailbox/rockchip-mailbox.c
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2016-03-14 23:46:55 +0100
committerJassi Brar <jaswinder.singh@linaro.org>2016-03-16 09:18:15 +0530
commitc5a9d1f30c066b7922a5f66b8c03a263d2f06a8c (patch)
tree33491c8c2837f03b7675effd7dabbbe1631a5301 /drivers/mailbox/rockchip-mailbox.c
parentf70ed3b5dc8b0810a01a24b198eca3f562aedc14 (diff)
mailbox: rockchip: avoid 64-bit division
The newly added rockchip mailbox driver causes a bug in the ARM allyesconfig build because of a division of a resource_size_t variable that may be 64 bit wide: drivers/mailbox/built-in.o: In function `rockchip_mbox_probe': :(.text+0x6614): undefined reference to `__aeabi_uldivmod' This adds a cast to size_t, which turns it into a 32-bit division in this case. This is safe because we know that we cannot possibly map a resource that is longer than what a pointer contains, and in practice it will be very short instead. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
Diffstat (limited to 'drivers/mailbox/rockchip-mailbox.c')
-rw-r--r--drivers/mailbox/rockchip-mailbox.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mailbox/rockchip-mailbox.c b/drivers/mailbox/rockchip-mailbox.c
index b79a2871227c..d702a204f5c1 100644
--- a/drivers/mailbox/rockchip-mailbox.c
+++ b/drivers/mailbox/rockchip-mailbox.c
@@ -213,7 +213,7 @@ static int rockchip_mbox_probe(struct platform_device *pdev)
return PTR_ERR(mb->mbox_base);
/* Each channel has two buffers for A2B and B2A */
- mb->buf_size = resource_size(res) / (drv_data->num_chans * 2);
+ mb->buf_size = (size_t)resource_size(res) / (drv_data->num_chans * 2);
mb->pclk = devm_clk_get(&pdev->dev, "pclk_mailbox");
if (IS_ERR(mb->pclk)) {

Privacy Policy