path: root/drivers/media/i2c
diff options
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>2015-08-18 05:31:09 -0300
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>2015-09-03 13:18:05 -0300
commit06d3f2e02024912d46e1fc8387c0284c9dfc36ad (patch)
treef4caf3e8e105dedd96fa392b6b45b3774615da46 /drivers/media/i2c
parentd071c833a0d30e7aae0ea565d92ef83c79106d6f (diff)
[media] tc358743: set direction of reset gpio using devm_gpiod_get
Commit 256148246852 ("[media] tc358743: support probe from device tree") failed to explicitly set the direction of the reset gpio. Use the optional flag of devm_gpiod_get to make up leeway. This is also necessary because the flag parameter will become mandatory soon. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media/i2c')
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c
index fe42c9a1cb78..a4efb6e2e7a2 100644
--- a/drivers/media/i2c/tc358743.c
+++ b/drivers/media/i2c/tc358743.c
@@ -1681,7 +1681,6 @@ static const struct v4l2_ctrl_config tc358743_ctrl_audio_present = {
#ifdef CONFIG_OF
static void tc358743_gpio_reset(struct tc358743_state *state)
- gpiod_set_value(state->reset_gpio, 0);
usleep_range(5000, 10000);
gpiod_set_value(state->reset_gpio, 1);
usleep_range(1000, 2000);
@@ -1783,7 +1782,7 @@ static int tc358743_probe_of(struct tc358743_state *state)
state->pdata.ths_trailcnt = 0x2;
state->pdata.hstxvregcnt = 0;
- state->reset_gpio = devm_gpiod_get(dev, "reset");
+ state->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
if (IS_ERR(state->reset_gpio)) {
dev_err(dev, "failed to get reset gpio\n");
ret = PTR_ERR(state->reset_gpio);

Privacy Policy