aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/pci/ttpci/budget-av.c
diff options
context:
space:
mode:
authorPeter Senna Tschudin <peter.senna@gmail.com>2012-09-06 11:23:53 -0300
committerMauro Carvalho Chehab <mchehab@redhat.com>2012-11-22 13:41:31 -0200
commitbc7c85e501d47a26d6659c94a1cdc02ec2dc4b3b (patch)
treeefd90038875abe4d12156550a6457548f73000e8 /drivers/media/pci/ttpci/budget-av.c
parentc4697d7f96f40cdc8f88bcdf4bf13d74ea11c4cc (diff)
[media] drivers/media/pci/ttpci/budget-av.c: fix error return code
Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/pci/ttpci/budget-av.c')
-rw-r--r--drivers/media/pci/ttpci/budget-av.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/pci/ttpci/budget-av.c b/drivers/media/pci/ttpci/budget-av.c
index 12ddb53c58dc..1f8b1bb0bf9f 100644
--- a/drivers/media/pci/ttpci/budget-av.c
+++ b/drivers/media/pci/ttpci/budget-av.c
@@ -1477,8 +1477,8 @@ static int budget_av_attach(struct saa7146_dev *dev, struct saa7146_pci_extensio
if (saa7113_init(budget_av) == 0) {
budget_av->has_saa7113 = 1;
-
- if (0 != saa7146_vv_init(dev, &vv_data)) {
+ err = saa7146_vv_init(dev, &vv_data);
+ if (err != 0) {
/* fixme: proper cleanup here */
ERR("cannot init vv subsystem\n");
return err;

Privacy Policy