aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/remoteproc/remoteproc_debugfs.c
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2015-11-20 18:26:07 +0100
committerOhad Ben-Cohen <ohad@wizery.com>2015-11-26 10:07:53 +0200
commit92792e48e2ae6051af30468a87994b5432da2f06 (patch)
tree3e35802656103fb2b4671e660c8dbdadf62066cd /drivers/remoteproc/remoteproc_debugfs.c
parent1ec218373b8ebda821aec00bb156a9c94fad9cd4 (diff)
remoteproc: avoid stack overflow in debugfs file
Recent gcc versions warn about reading from a negative offset of an on-stack array: drivers/remoteproc/remoteproc_debugfs.c: In function 'rproc_recovery_write': drivers/remoteproc/remoteproc_debugfs.c:167:9: warning: 'buf[4294967295u]' may be used uninitialized in this function [-Wmaybe-uninitialized] I don't see anything in sys_write() that prevents us from being called with a zero 'count' argument, so we should add an extra check in rproc_recovery_write() to prevent the access and avoid the warning. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: 2e37abb89a2e ("remoteproc: create a 'recovery' debugfs entry") Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
Diffstat (limited to 'drivers/remoteproc/remoteproc_debugfs.c')
-rw-r--r--drivers/remoteproc/remoteproc_debugfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
index 9d30809bb407..916af5096f57 100644
--- a/drivers/remoteproc/remoteproc_debugfs.c
+++ b/drivers/remoteproc/remoteproc_debugfs.c
@@ -156,7 +156,7 @@ rproc_recovery_write(struct file *filp, const char __user *user_buf,
char buf[10];
int ret;
- if (count > sizeof(buf))
+ if (count < 1 || count > sizeof(buf))
return count;
ret = copy_from_user(buf, user_buf, count);

Privacy Policy