path: root/drivers/scsi
diff options
authorXiang Chen <chenxiang66@hisilicon.com>2018-01-18 00:46:54 +0800
committerMartin K. Petersen <martin.petersen@oracle.com>2018-01-22 20:03:59 -0500
commit0d762b3af2a5b5095fec18aa4d61f408638aa9ca (patch)
tree2568d279b38e9ae91b8a73adc2260bd0c1621611 /drivers/scsi
parent6379c56070b9ee32ae2b3efa51e121242042e72d (diff)
scsi: hisi_sas: fix a bug in hisi_sas_dev_gone()
When device gone, NULL pointer can be accessed in free_device callback if during SAS controller reset as we clear structure sas_dev prior. Actually we can only set dev_type as SAS_PHY_UNUSED and not clear structure sas_dev as all the members of structure sas_dev will be re-initialized after device found. Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com> Signed-off-by: John Garry <john.garry@huawei.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi')
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index 791462d7fbfc..2d4dbed03ee3 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -796,7 +796,6 @@ static void hisi_sas_dev_gone(struct domain_device *device)
hisi_hba->hw->clear_itct(hisi_hba, sas_dev);
device->lldd_dev = NULL;
- memset(sas_dev, 0, sizeof(*sas_dev));
if (hisi_hba->hw->free_device)

Privacy Policy