aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/xen
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-11-03 09:20:47 +0000
committerBoris Ostrovsky <boris.ostrovsky@oracle.com>2017-11-03 11:38:45 -0400
commit773aaadcd474d0a4f85915787118891d47b60983 (patch)
tree64c7aa37f4d025fb830fa0f1dc39420067977fcc /drivers/xen
parent95110ac88d5139c73eef6ede37eff23c4089f4f2 (diff)
xen/pvcalls: remove redundant check for irq >= 0
This is a moot point, but irq is always less than zero at the label out_error, so the check for irq >= 0 is redundant and can be removed. Detected by CoverityScan, CID#1460371 ("Logically dead code") Fixes: cb1c7d9bbc87 ("xen/pvcalls: implement connect command") Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Juergen Gross <jgross@suse.com> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Diffstat (limited to 'drivers/xen')
-rw-r--r--drivers/xen/pvcalls-front.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 60a0ad81d4cf..2925b2f095ed 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -351,9 +351,7 @@ static int create_active(struct sock_mapping *map, int *evtchn)
return 0;
out_error:
- if (irq >= 0)
- unbind_from_irqhandler(irq, map);
- else if (*evtchn >= 0)
+ if (*evtchn >= 0)
xenbus_free_evtchn(pvcalls_front_dev, *evtchn);
kfree(map->active.data.in);
kfree(map->active.ring);

Privacy Policy