aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/xen
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-11-03 08:42:02 +0000
committerBoris Ostrovsky <boris.ostrovsky@oracle.com>2017-11-03 11:38:27 -0400
commit95110ac88d5139c73eef6ede37eff23c4089f4f2 (patch)
treece0fa7aa52ff330e56e6be4d10e2ab38c8ac0e90 /drivers/xen
parentb5494ad83fb52a8e5a7dc1d30cb42cbca5d617f1 (diff)
xen/pvcalls: fix unsigned less than zero error check
The check on bedata->ref is never true because ref is an unsigned integer. Fix this by assigning signed int ret to the return of the call to gnttab_claim_grant_reference so the -ve return can be checked. Detected by CoverityScan, CID#1460358 ("Unsigned compared against 0") Fixes: 219681909913 ("xen/pvcalls: connect to the backend") Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Juergen Gross <jgross@suse.com> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Diffstat (limited to 'drivers/xen')
-rw-r--r--drivers/xen/pvcalls-front.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index ed94ea0b4b8e..60a0ad81d4cf 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -1186,11 +1186,10 @@ static int pvcalls_front_probe(struct xenbus_device *dev,
ret = gnttab_alloc_grant_references(1, &gref_head);
if (ret < 0)
goto error;
- bedata->ref = gnttab_claim_grant_reference(&gref_head);
- if (bedata->ref < 0) {
- ret = bedata->ref;
+ ret = gnttab_claim_grant_reference(&gref_head);
+ if (ret < 0)
goto error;
- }
+ bedata->ref = ret;
gnttab_grant_foreign_access_ref(bedata->ref, dev->otherend_id,
virt_to_gfn((void *)sring), 0);

Privacy Policy