path: root/drivers
diff options
authorDavid Herrmann <dh.herrmann@gmail.com>2013-09-09 18:33:54 +0200
committerJiri Kosina <jkosina@suse.cz>2013-09-26 11:03:29 +0200
commit19872d20c890073c5207d9e02bb8f14d451a11eb (patch)
tree7f83152f8b341304cf4134fe85ab50d349d15ab1 /drivers
parent84fca9f38c5d646e95cdeef70e41cf15db549b95 (diff)
HID: uhid: allocate static minor
udev has this nice feature of creating "dead" /dev/<node> device-nodes if it finds a devnode:<node> modalias. Once the node is accessed, the kernel automatically loads the module that provides the node. However, this requires udev to know the major:minor code to use for the node. This feature was introduced by: commit 578454ff7eab61d13a26b568f99a89a2c9edc881 Author: Kay Sievers <kay.sievers@vrfy.org> Date: Thu May 20 18:07:20 2010 +0200 driver core: add devname module aliases to allow module on-demand auto-loading However, uhid uses dynamic minor numbers so this doesn't actually work. We need to load uhid to know which minor it's going to use. Hence, allocate a static minor (just like uinput does) and we're good to go. Reported-by: Tom Gundersen <teg@jklm.no> Signed-off-by: David Herrmann <dh.herrmann@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers')
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c
index 5bf2fb785844..93b00d76374c 100644
--- a/drivers/hid/uhid.c
+++ b/drivers/hid/uhid.c
@@ -615,7 +615,7 @@ static const struct file_operations uhid_fops = {
static struct miscdevice uhid_misc = {
.fops = &uhid_fops,
+ .minor = UHID_MINOR,
.name = UHID_NAME,
@@ -634,4 +634,5 @@ module_exit(uhid_exit);
MODULE_AUTHOR("David Herrmann <dh.herrmann@gmail.com>");
MODULE_DESCRIPTION("User-space I/O driver support for HID subsystem");

Privacy Policy