path: root/drivers
diff options
authorTang Junhui <tang.junhui@zte.com.cn>2018-02-07 11:41:45 -0800
committerJens Axboe <axboe@kernel.dk>2018-02-07 12:50:01 -0700
commit7f4fc93d4713394ee8f1cd44c238e046e11b4f15 (patch)
tree335e2ce8e0eb29e7b21878dea04d9c3472eaa9b2 /drivers
parent7a5e3ecbe5b7b58e9a78a3738b28244982822e1c (diff)
bcache: return attach error when no cache set exist
I attach a back-end device to a cache set, and the cache set is not registered yet, this back-end device did not attach successfully, and no error returned: [root]# echo 87859280-fec6-4bcc-20df7ca8f86b > /sys/block/sde/bcache/attach [root]# In sysfs_attach(), the return value "v" is initialized to "size" in the beginning, and if no cache set exist in bch_cache_sets, the "v" value would not change any more, and return to sysfs, sysfs regard it as success since the "size" is a positive number. This patch fixes this issue by assigning "v" with "-ENOENT" in the initialization. Signed-off-by: Tang Junhui <tang.junhui@zte.com.cn> Reviewed-by: Michael Lyle <mlyle@lyle.org> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers')
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
index 4a6a697e1680..a7552f509f50 100644
--- a/drivers/md/bcache/sysfs.c
+++ b/drivers/md/bcache/sysfs.c
@@ -198,7 +198,7 @@ STORE(__cached_dev)
struct cached_dev *dc = container_of(kobj, struct cached_dev,
- ssize_t v = size;
+ ssize_t v;
struct cache_set *c;
struct kobj_uevent_env *env;
@@ -275,6 +275,7 @@ STORE(__cached_dev)
if (bch_parse_uuid(buf, dc->sb.set_uuid) < 16)
return -EINVAL;
+ v = -ENOENT;
list_for_each_entry(c, &bch_cache_sets, list) {
v = bch_cached_dev_attach(dc, c);
if (!v)
@@ -282,7 +283,7 @@ STORE(__cached_dev)
pr_err("Can't attach %s: cache set not found", buf);
- size = v;
+ return v;
if (attr == &sysfs_detach && dc->disk.c)

Privacy Policy