path: root/drivers
diff options
authorJakub Kicinski <jakub.kicinski@netronome.com>2018-02-07 20:27:12 -0800
committerDaniel Borkmann <daniel@iogearbox.net>2018-02-08 11:59:50 +0100
commitb7d99235473ad3a550f8eb05bd4469edadf1c8e6 (patch)
tree0f897f1ba4aea853430402787fdd0d043f0f30a9 /drivers
parent035d808f7cfd578dc210b584beb17e365f34d39a (diff)
nfp: bpf: fix immed relocation for larger offsets
Immed relocation is missing a shift which means for larger offsets the lower and higher part of the address would be ORed together. Fixes: ce4ebfd859c3 ("nfp: bpf: add helpers for updating immediate instructions") Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Reviewed-by: Jiong Wang <jiong.wang@netronome.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Diffstat (limited to 'drivers')
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_asm.c b/drivers/net/ethernet/netronome/nfp/nfp_asm.c
index 3f6952b66a49..1e597600c693 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_asm.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_asm.c
@@ -107,7 +107,7 @@ u16 immed_get_value(u64 instr)
if (!unreg_is_imm(reg))
reg = FIELD_GET(OP_IMMED_B_SRC, instr);
- return (reg & 0xff) | FIELD_GET(OP_IMMED_IMM, instr);
+ return (reg & 0xff) | FIELD_GET(OP_IMMED_IMM, instr) << 8;
void immed_set_value(u64 *instr, u16 immed)

Privacy Policy