aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHans Verkuil <hverkuil-cisco@xs4all.nl>2019-04-01 14:06:29 +0200
committerHans Verkuil <hverkuil-cisco@xs4all.nl>2019-04-01 14:09:56 +0200
commit0efd87d4058697347797239cad13cb4231438f19 (patch)
treefa0cbcea937ab82af78a0085087ff9d77f1b8e03
parentc9932ff4c23198301b821c06224235859c215bbb (diff)
v4l2-compliance: fix and comment out qbuf test
The fail_on_test(qbuf()) check was missing a !. But if after this correctly-failing qbuf() the querybuf ioctl is called again, all the request information is dropped from the result. So comment this out while a investigation this. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Fixes: 7ee189ecae01 ("v4l2-compliance: fix request API test")
-rw-r--r--utils/v4l2-compliance/v4l2-test-buffers.cpp4
1 files changed, 3 insertions, 1 deletions
diff --git a/utils/v4l2-compliance/v4l2-test-buffers.cpp b/utils/v4l2-compliance/v4l2-test-buffers.cpp
index 94420326..781a23f4 100644
--- a/utils/v4l2-compliance/v4l2-test-buffers.cpp
+++ b/utils/v4l2-compliance/v4l2-test-buffers.cpp
@@ -1814,7 +1814,9 @@ int testRequests(struct node *node, bool test_streaming)
int err = buf.qbuf(node);
if (!err) {
fail_on_test(!supports_requests);
- fail_on_test(buf.qbuf(node));
+ // After this call querybuf won't set
+ // V4L2_BUF_FLAG_REQUEST_FD. Disable this test for now.
+ // fail_on_test(!buf.qbuf(node));
} else {
fail_on_test(supports_requests);
fail_on_test(err != EBADR);

Privacy Policy