diff options
authorHans Verkuil <hverkuil-cisco@xs4all.nl>2018-11-29 13:02:52 +0100
committerHans Verkuil <hverkuil-cisco@xs4all.nl>2018-11-29 13:02:52 +0100
commit8c5a3e1d74315d920327fc386867d2d611fb8768 (patch)
parentf2af3d3e99fb1a7ec215b4b47659e6e19783494b (diff)
cec-compliance: fix wrong test for no HPD in testRemote()
If the 'standby' flag for the test-to-be-performed is set to true, then the code needs to check is the remote device pulls down the HPD when in standby. In that case the test should be skipped since it is not a valid test for such devices. However, the check was wrong and these tests were still performed. Fix the check. Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
1 files changed, 1 insertions, 1 deletions
diff --git a/utils/cec-compliance/cec-test.cpp b/utils/cec-compliance/cec-test.cpp
index 0868c248..414a23f0 100644
--- a/utils/cec-compliance/cec-test.cpp
+++ b/utils/cec-compliance/cec-test.cpp
@@ -1434,7 +1434,7 @@ void testRemote(struct node *node, unsigned me, unsigned la, unsigned test_tags,
struct cec_log_addrs laddrs = { };
doioctl(node, CEC_ADAP_G_LOG_ADDRS, &laddrs);
- if (node->phys_addr == CEC_PHYS_ADDR_INVALID)
+ if (!laddrs.num_log_addrs)
node->in_standby = tests[i].subtests[j].in_standby;

Privacy Policy