Age | Commit message (Collapse) | Author | Files | Lines |
|
There are two almost-identical-but-not-quite possible pixel aspect
ratios in use for PAL: either 59:54 or 12:11. Since all our drivers
report 59:54 this is the one we should use in qv4l2 as well.
See also http://en.wikipedia.org/wiki/Pixel_aspect_ratio for more
information on why there are two competing pixel aspect ratios.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Main change: the 16x9 widescreen vertical lines for PAL/NTSC have been
corrected.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Don't chop off the "Controls" text in the tab name: it turns out that
leaving that off makes it hard to tell the difference between tabs
that are setup by qv4l2 and tabs that contain controls from the driver.
If someone can come up with a better way of doing this then that would
be welcome, but for now this is the best I can come up with.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
The information shown can be seen in the status bar
of the main window. The eventfilter that shows the bottom
layout can also be percieved as annoying.
Signed-off-by: Anton Arbring <aarbring@cisco.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Initialize reserved fields and a v4l2_format struct.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Mostly uninitialized fields, but there was also one inverted get_interval result
check.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
This makes it more obvious what is going on.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
The m_tpgLimRGBRange pointer was non-NULL when it shouldn't
be. Set it to NULL when the device is closed, that's the correct
place since after that it is invalid until a new device is opened.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
From Hans de Goede:
Originally this was not possible, which is why I went with the fixed buffer
(IIRC). But later on we started dis-allowing changing various parameters
with buffers mapped, because allowing that was just a bad idea.
In order to allow dynamic allocation of convert_mmap_buf, we need to make
sure that:
a) It is not used whenever dest_fmt changes, since it is used
to store destination fmt data and should always be at least
dest_fmt.fmt.pix.sizeimage bytes. I've just checked and all
places which change dest_fmt first call v4l2_check_buffer_change_ok()
which ensures that convert_mmap_buf is not used, frees it and marks
it as MAP_FAILED.
b) It is not allocated before dest_fmt gets set. It is allocated in
2 places:
1) On DQBUF, which only can be done after a stream-on, at which point
dest_fmt must be set.
2) on v4l2_mmap, which requires the caller having done a QUERYBUF,
and thus a REQBUFS, so dest_fmt must be set at this point.
So long story short, yes doing dynamic alloc should work fine. I
suggest introducing a v4l2_ensure_convert_mmap_buf function for
this which checks if convert_mmap_buf == MAP_FAILED and when it
is allocs a buffer of dest_fmt.fmt.pix.sizeimage bytes rounded
up to a multiple PAGE_SIZE. If convert_mmap_buf != MAP_FAILED
and thus the buffer is already allocated it should simply
return success.
Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
|
The v4l2_pix_format struct has been extended with new fields. Let libv4l-mplane
make use of that so that the v4l2_pix_format_mplane 'flags' field can be reported
in v4l2_pix_format as well.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Instead of checking for success, check for a result != ENOTTY.
Unfortunately this will fail for kernels older than 3.1 when the
default return code for a non-existing ioctl was EINVAL. All I
can say is: upgrade your kernel, there is a reason EINVAL was a
bad idea...
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Use setReadOnly instead for QLineEdit widgets.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
This allows you to copy-and-paste the text and to scroll through
it if the text is longer than the widget.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
The segment number of bit 3 of the DI code is 0, increasing to segment
number 3 for bit 0. The code assumed segment S matched bit S, but it
is bit (3 - S) instead.
Very confusing choice in the standard, so I'm not surprised this was
broken.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
If just the TA bit changed, then nothing was printed by rds-ctl.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
To simplify this work g/s_selection helper functions are added to the
helper headers that will fallback to S/G_CROP if necessary.
This patch also fixes a bug where the buffer field was never set when
generating a FIELD_ALTERNATE video output stream.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
buf.field was set to the next field instead of the current field.
Reordered the code to keep both buf.field and tpg_s_field in sync.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Those fields were initialized to 0 instead of to TPG_MOVE_NONE.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
If --clear-bitmap or --clear-clips were combined with --set-fmt-overlay without
any other changes, then those options were ignored and VIDIOC_S_FMT was never
called. Add a check whether those options were defined to ensure S_FMT is
actually called.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
Signed-off-by: Marcel Mol <marcel@mesa.nl>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
allow C++ apps to use crc32
Signed-off-by: André Roth <neolynx@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
These are quite common and off the shelf, universal
Ku band LBNFs. They started been used in Europe
after the lunch of the Astra 1E and can be found
pretty much everywhere.
Signed-off-by: Reynaldo H. Verdejo Pinochet <r.verdejo@sisa.samsung.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
Adds options to allow the buffer dqbuf to happen on one thread while
the qbuf happens on another. This is useful to test concurrency access to
the v4l2 features. To enable this, 3 new options were added:
t: enable threaded mode (off by default and will use the loop)
b: enable blocking io mode (off by default
s: how much the consumer thread will sleep after reading a buffer, this is to
simulate the time that it takes to process a buffer in a real application
(in ms)
For example, you can simulate an application that takes 1s to process a buffer
with:
v4l2grab -t -b -s 1000
Signed-off-by: Thiago Santos <ts.santos@sisa.samsung.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Removed unnecessary header file to fix issue with some compilers.
Signed-off-by: Rob Barker <robert.barker@redembedded.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
It should never try to enable a protocol not supported, as
the Kernel will give an error and reset to none.
That's a problem when -p all option is used. So, mask the
protocols to make this option to work.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
channel should be a pointer, as it will be allocated internally,
otherwise we'll have a double de-allocation when freeing DVB
scan structures.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
This parser is not 100%, but it properly handles the I2C
registers, making easier to understand the parsed logic.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
With raw decoders, sometimes it is interesting to be able to
select all decoders, as it helps to use a raw driver to test if
a given IR is producing scancodes.
Add "all" to the list of accepted protocols.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
Hook the test pattern generator into qv4l2, allowing it to be used
as a generator for video output devices. Careful attention has been
given to correct colorspace and RGB quantization handling.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
The regex were not parsing right those logs. Fix it, and add
the timestamps to the dumps.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
Colors not belonging to the CSC colorbar should just be accepted as is.
The contrast color for the CSC colorbar should be suitable for CSC
conversion as well.
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
|
|
Just show a simple waveform of the first 1025 samples of the I and Q samples
in each captured buffer. It's simple but remarkably effective.
Currently only the CU8 format is supported.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Very minor changes only, mostly a file rename, but this makes it easier
to keep things synchronized.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
I've been digging into why on my laptop the stacked frames in the Input section
appear shifted to the right.
The reason is that the initial loop in fixWidth() sets the minimumwidth
without looking at what the widget is. After some debugging I found out that it
was setting the minimumwidth for the wFrameSR widget.
So I added checks that it only changes it for comboboxes, spinboxes and sliders.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Error messages in case of a missing signal were not displayed, and the
querystd return code check was inverted.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Rework qv4l2 so that output devices (vbi and video out) are supported.
Also disable the streaming option for devices that do not support it.
This is (for now) also disabled for SDR since I don't know how to show
the captured SDR data in a meaningful way.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
The widgets individual minimum sizes are enough
and the height calculation causes problems on
high dpi screens.
Signed-off-by: Anton Arbring <aarbring@cisco.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Make sure buffersize is set.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
Some more V4L2 API enhancements were merged, so sync with that.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
The source change event was only subscribed for the first event, not
for any of the others. Apparently an 'if-while' construct is legal (?!),
but I meant to write 'if () { do {} while() }'.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|