aboutsummaryrefslogtreecommitdiffstats
path: root/src/libcamera
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2022-09-03 17:44:00 +0300
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>2022-09-07 00:32:10 +0300
commit6225d647b47982833fa654bf9cf65eb8c04d2036 (patch)
treed637ce08b3931db06ffb5acd15a50419eeea5096 /src/libcamera
parentf98919307e411c57f24de7587b22ac90a7850bdc (diff)
pipeline: uvcvideo: Fail match() if the camera has no supported format
A UVC device could expose only formats that are not supported by libcamera. The pipeline handler doesn't currently consider this as an error, and happily creates a camera. The camera won't be usable, and worse, generateConfiguration() and validate() will crash as those functions assume that at least one format is supported. Fix this by failing match() if none of the formats exposed by the camera are supported. Log an error message in that case to notify the user. Bug: https://bugs.libcamera.org/show_bug.cgi?id=145 Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Tested-by: Christian Rauch <Rauch.Christian@gmx.de>
Diffstat (limited to 'src/libcamera')
-rw-r--r--src/libcamera/pipeline/uvcvideo/uvcvideo.cpp7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp
index be0fbaea..a2819545 100644
--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp
+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp
@@ -457,6 +457,13 @@ int UVCCameraData::init(MediaDevice *media)
}
}
+ if (formats_.empty()) {
+ LOG(UVC, Error)
+ << "Camera " << id_ << " (" << media->model()
+ << ") doesn't expose any supported format";
+ return -EINVAL;
+ }
+
/* Populate the camera properties. */
properties_.set(properties::Model, utils::toAscii(media->model()));

Privacy Policy