aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorYunjian Wang <wangyunjian@huawei.com>2021-04-12 22:41:18 +0800
committerTony Nguyen <anthony.l.nguyen@intel.com>2021-05-07 09:35:49 -0700
commit38318f23a7ef86a8b1862e5e8078c4de121960c3 (patch)
tree6b42cf8cfff18559520bcaae40ffc12c7f920c29
parentae4393dfd472b194c90d75d2123105fb5ed59b04 (diff)
i40e: Fix use-after-free in i40e_client_subtask()
Currently the call to i40e_client_del_instance frees the object pf->cinst, however pf->cinst->lan_info is being accessed after the free. Fix this by adding the missing return. Addresses-Coverity: ("Read from pointer after free") Fixes: 7b0b1a6d0ac9 ("i40e: Disable iWARP VSI PETCP_ENA flag on netdev down events") Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
-rw-r--r--drivers/net/ethernet/intel/i40e/i40e_client.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c
index a2dba32383f6..32f3facbed1a 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_client.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_client.c
@@ -375,6 +375,7 @@ void i40e_client_subtask(struct i40e_pf *pf)
clear_bit(__I40E_CLIENT_INSTANCE_OPENED,
&cdev->state);
i40e_client_del_instance(pf);
+ return;
}
}
}

Privacy Policy