aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/dvb-frontends/m88ds3103.c
diff options
context:
space:
mode:
authorSean Young <sean@mess.org>2020-04-16 16:22:15 +0200
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>2020-04-29 11:58:27 +0200
commitc4ed27cfed45c16c2dd16c9fa3b883e306177e40 (patch)
treeb1ce0fb54f4284ffe7012c4392523917209739ca /drivers/media/dvb-frontends/m88ds3103.c
parent4e5552b23f9fdfdca008a1ab05725daa471f5a83 (diff)
media: m88ds3103: error in set_frontend is swallowed and not reported
Bail out if registers can not be updated. Addresses-Coverity-ID: 1461655 ("Code maintainability issues") Reported-by: coverity-bot <keescook+coverity-bot@chromium.org> Fixes: e6089feca460 ("media: m88ds3103: Add support for ds3103b demod") Signed-off-by: Sean Young <sean@mess.org> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/media/dvb-frontends/m88ds3103.c')
-rw-r--r--drivers/media/dvb-frontends/m88ds3103.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c
index bc356ac4fe5e..f204e715bc59 100644
--- a/drivers/media/dvb-frontends/m88ds3103.c
+++ b/drivers/media/dvb-frontends/m88ds3103.c
@@ -980,6 +980,8 @@ static int m88ds3103_set_frontend(struct dvb_frontend *fe)
goto err;
ret = m88ds3103_update_bits(dev, 0xc9, 0x08, 0x08);
+ if (ret)
+ goto err;
}
dev_dbg(&client->dev, "carrier offset=%d\n",

Privacy Policy