cec-ctl: showTopology(): fix level wraparound bug

The unsigned level variable could wrap around if you have a
weird situation where one device has physical address 4.0.0.0
and another 3.1.0.0. When this happens cec-ctl -S would start
spewing a zillion tab characters.

Ensure that level is never less than 1.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

1 files changed, 4 insertions, 2 deletions

diff --git a/utils/cec-ctl/cec-ctl.cpp b/utils/cec-ctl/cec-ctl.cpp
index 72b80aa9..f6aa7c7d 100644
--- a/utils/cec-ctl/cec-ctl.cpp
+++ b/utils/cec-ctl/cec-ctl.cpp
@@ -698,7 +698,7 @@ static int showTopology(struct node *node)
 
 	memcpy(pas, phys_addrs, sizeof(pas));
 	std::sort(pas, pas + 16);
-	unsigned level = 0;
+	int level = 0;
 	unsigned last_pa_mask = 0;
 
 	if ((pas[0] >> 8) == 0xffff)
@@ -723,7 +723,9 @@ static int showTopology(struct node *node)
 			level--;
 		}
 		printf("\t");
-		for (unsigned j = 0; j < level; j++)
+		if (level < 1)
+			level = 1;
+		for (int j = 0; j < level; j++)
 			printf("    ");
 		printf("%x.%x.%x.%x: %s\n", cec_phys_addr_exp(pa),
 		       cec_la2s(la));