| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
Always log the translated vendor ID string if available.
This helps debugging.
Also add a new vendor ID string.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
It is only needed if BPF is effectively used and the package is compiled for a
systemd based target.
Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Sean Young <sean@mess.org>
|
|
Import systemd's official suggestion [1] how this should be handled in packages
using autoconf. A side effect of this is the removal of the hardcoded fallback
path "/lib/systemd/system" which leaks build host information when cross
compiling v4l-utils and therefore defeats reproducible builds.
[1] https://www.freedesktop.org/software/systemd/man/daemon.html#Installing%20systemd%20Service%20Files
Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Sean Young <sean@mess.org>
|
|
At least v4l2-ctl -l now shows the proper type instead of 'unknown'.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
window()->windowHandle() can return NULL, in that case fallback
to a 1920x1080 screen resolution. Still better than a crash.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Fixed incorrect DisplayID timings (swapped front and backporches)
and wrong aspect ratio (1:1 instead of 16:9).
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Provide a more detailed description of the various EDID types.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
The first DTD had a wrong vsync (6 instead of 5). Fixed.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
This:
v4l2-ctl -c auto_exposure=3,exposure_time_absolute=100,auto_exposure=1,exposure_time_absolute=200
should turn into a single VIDIOC_S_EXT_CTRLS call with 4 controls instead
of 2 controls with just the last value for each control.
This helps testing VIDIOC_S_EXT_CTRLS to check if drivers handle this
correctly (only the last value for each control should be used).
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
|
|
|
|
Add a new --show-edid option that dumps the EDID you would write
with --set-edid.
Updated existing EDIDs (fixing small edid-decode conformity warnings)
and add new EDIDs for displayport and 3 and 4 block EDIDs.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Don't warn about unexpected sequence counters for metadata streams:
the sequence counter is typically linked to the video capture to sync
the metadata with the video data. So the sequence counter would start
at a non-zero value and produce a warning when it shouldn't.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
|
|
With gcc 11 the min/max defines clash with what gcc provides,
so rename these defines. They are only used in the min3/max3
defines, so the change it kept to a minimum.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reported-by: Gregor Jasny <gjasny@googlemail.com>
|
|
Verify that QUERY_EXT_CTRLS and QUERYCTRLS handle enumerating
only regular controls or only compound controls correctly.
Before v4l2-compliance only checked that enumerating all controls
was done correctly.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Check that the driver doesn't make up pixelformat descriptions.
It should be left to the v4l2 core.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Also drop the 'grep -v V4L2_PIX_FMT_H264_SLICE' in sync-with-kernel.sh.
This is now part of the stable API, so allow this.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Sync with 5.12-rc1
Signed-off-by: Sean Young <sean@mess.org>
|
|
Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
Signed-off-by: Sean Young <sean@mess.org>
|
|
Add comments to mention that keymap files are generated, and list which
tool was used to generate them and the kernel source filename.
This should make it less likely that generated files are used as
examples to contribute keymaps from, and more likely that upstream
changes are channeled through the right source tree.
Signed-off-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Sean Young <sean@mess.org>
|
|
Gettext 0.19.8 wants to see AM_GNU_GETTEXT_VERSION, but gettext 0.21
wants AM_GNU_GETTEXT_REQUIRE_VERSION.
Test if AM_GNU_GETTEXT_REQUIRE_VERSION is supported and use that,
otherwise fall back to AM_GNU_GETTEXT_VERSION.
This also prevents gettextize from overwriting configure.ac with
an updated AM_GNU_GETTEXT_VERSION version number, which was really
annoying since configure.ac is under version control.
Tested with both gettext versions.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Suggested-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
AM_GNU_GETTEXT_VERSION was changed accidentally to version 0.21 in
the previous commit, but this fails on some distros with an older
gettext. Go back to the old AM_GNU_GETTEXT_VERSION([0.19.8]).
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
If audio_out_delay is unused, then still check that:
1) the value is not a reserved value,
2) that the value is set to 1 as the recommended (sane) default.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
When V=0, suppress:
- make entering/leaving messages
- some scripting logic called on a few makefiles.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
The print message there can dereference a null pointer, if
the first check is true.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
Print an error if it can't adjust the size of the RCV buffer.
As it might still work, let the code to continue.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
Use a define and add a few checks in order to avoid potential
mistakes in the future.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
Clearly, the free() call should be for args.server ;-)
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
err_cnt is unsigned. So, it can't be below zero.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
If something goes wrong, just sleep and re-try inside the
timeout loop.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
It doesn't make sense to have a return NULL inside it.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
The current logic is broken for default values,
due to a misplaced '}'.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
descriptior->descriptor
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
Reject it when the size doesn't match what's expected.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
Add a check if the CA descriptor has at least 4 bytes, and
cleanup the logic, in order to avoid using magic numbers,
by using offsetof() and sizeof().
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
Check if the size has the expected value.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
This is a very simple descriptor. Make the code equally simple.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
Instead of relying that all descriptors will report the
error conditions, add a generic handler, as it may help to
discover hidden problems.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
A fixup patch actually broke the parser, as it was copying data
to the wrong place.
Yet, while testing it, it was noticed some streams that have a
descriptor 0xa1 whose the language code is bogus:
| pcr PID 1539
|\ elementary service - 3 elementaries
|- elementary 0
|- | stream type 0x00
|- | PID 1
|- | Language .'. (0xcf 0x27 0x04)
|- elementary 1
|- | stream type 0x04
|- | PID 0
|- | Language ..& (0x01 0xcf 0x26)
|- elementary 2
|- | stream type 0x05
|- | PID 1280
|- | Language ... (0x00 0x01 0xcf)
So, clearly this is not an ATSC descriptor. So, improve the
logic to allow displaying invalid language codes, plus
check if the descriptor's size is what it was expected.
Fixes: 868ca548b10a ("libdvbv5: fix init of the ATSC service location")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
The realloc() call assumes that, when realloc() succeeds,
the return pointer is identical.
This should always be the case here, as the code is reducing
the size of the struct. Yet, an assumption like that can
be dangerous, if used with a library different than the
standard glibc.
So, let's store the returned pointer.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
The logic which detects changes at the DVB devices can leak
data or try to do double-free, if errors occur.
Fix it.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
If errors occur, ensure that the message buffer will be freed.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
Fix a few warnings from Coverity. Nothing really important,
but it helps to have a better code.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
If something goes wrong, ensure that the allocated msg
and ringbuf will be freed.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
The test condition is allowing to use a value bigger than
the size of the event_type. Fix it.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
In practice, this condition is very unlikely to occur,
as it would depend on upgrading a Kernel with a newer DTV
property while using an older v4l-utils package.
As we don't add any new DTV property for quite a while,
I would say that only if someone would run a brand new
v4l2-utils and a very old Kernel (like 2.6.x), something
like that would happen.
In any case, better to be safe than sorry.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
The memcpy() was not filling the initial values of this
descriptor, as it would be expected.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
There are some cut-and-paste related issues, which makes the
array size to be passed wrong when calling cnr_arr_to_qual().
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
If the library falls back to DVBv3 API, ensure that the
frontend parameters will be set to zero before start filling
them.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
|
There's a possible condition that the start time would be
used before its init: if dvb_dev_read() returns -EOVERFLOW
when first == 1.
In order to prevent that, initialize it eariler, while
keeping the reset condition later on.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
|
