| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
Until now, if the remote device was in standby the test would just
abort with a message that the remote device should be woken up manually.
This patch changes this to attempt to automatically wake up the remote
device. Basically it adds the 'Wake up' to the core tests, but it is
only run if the remote device was in standby, otherwise it is skipped.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
|
|
Signed-off-by: Gregor Jasny <gjasny@googlemail.com>
|
|
Codec devices must have entity function MEDIA_ENT_F_PROC_VIDEO_ENCODER
or _DECODER. Check this.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Fix confusing messages like this:
Transient state after 0 s, stable state On after 0 s
This really means that no transient state was reported, and only
a stable state.
Report this as such.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
"Device is woken up" suggests that the device has just woken up,
but what is actually meant is: "Wait for device to wake up".
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
The poll_stable_power_status() function reported the unresponsive_time,
which is not the duration the device is unresponsive during a power state
transition, but the time of the last unresponsive attempt since the start
of that state transition.
That's not what was intended, so change unresponsive_time to
unresponsive_cnt where we keep track of the number of unresponsive
attempts. Adjust the messages accordingly.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Log the version info earlier and also log the command line arguments.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
There are too many issues with the vidtv driver. So for now drop it
from the list of drivers that the 'mc' target activates.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Since DVB can also use the media controller, add 'vidtv' to the
list of drivers that the 'mc' option enables.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Add a 'date' command at the beginning and the end to make it easier
to see how much time the script takes.
Also show the kernel version and v4l2-compliance version at the
start to check that the expected versions are used for testing.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
There was one other place where the scaler had to be configured.
Add this.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
With the new vimc scaler patch the scaler has to be configured
correctly, otherwise the vimc test will fail.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Add -E (exit-on-fail) and -W (exit-on-warn) options.
This helps debugging test failures.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Often a return code is checked against allowed values. It is
very useful if that return code is shown in the fail message
if it has a wrong value. Add fail_on_test_val() for that.
Use it in v4l2-test-buffers.cpp to start with.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
This returns back non-coherent (previously known as NON_COHERENT)
memory flag and buffer cache management hints testing (for VB2_MEMORY_MMAP
buffers).
Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
This merges the new vb2 non-coherent API.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Air conditioner codes typically have 100 pulse/space pairs (12 bytes +
headers). The resulting raw IR line length is 1063, which exceeds the
current 1024 byte buffer, and results in an error trying to parse the
line.
The buffers used to read pulse/space files are significantly larger than
needed so this decreases their size, and allocates the difference to the
buffer used to read raw IR files in order to keep the total size of
buffers the same.
Signed-off-by: Norman Rasmussen <norman@rasmussen.co.za>
Signed-off-by: Sean Young <sean@mess.org>
|
|
When a 32-bit application is running on a 64-bit kernel then there
can be two different VIDIOC_DQEVENT ioctls: one using 32-bit time
fields, one using 64-bit time fields (year 2038 safe).
Test that each version (if available) reports sane values.
This test is only run from the 32-bit version of v4l2-compliance.
It currently only supports VIDIOC_DQEVENT and not yet the ioctls
that use struct v4l2_buffer.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
This check was missing, add it.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
- The hdmi-4k-600mhz version didn't set SCDC support
- Add support for the new Video Format Preference Data Block
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
sizeof(*msg->cmd) should have been sizeof(msg->cmd).
Also, call strncpy with siz - 1 instead of siz to avoid this
compiler warning:
CC libdvbv5_la-dvb-dev-remote.lo
In function ‘my_strlcpy’,
inlined from ‘send_buf.isra.0.constprop’ at dvb-dev-remote.c:350:2:
dvb-dev-remote.c:121:7: warning: ‘strncpy’ output truncated copying 1 byte from a string of length 12 [-Wstringop-truncation]
121 | rc = strncpy(dst, src, siz);
| ^~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Avoids having to call the constructor as it forwards the arguments
directly.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
The members can be initialized directly, allowing to remove the
onstructor.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
If the remote device doesn't support the Timer Feature, then do
not attempt to test for timer errors or overlapped timers.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
The current wait time of 3 seconds is a bit too short, increase to
10 seconds.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Drop the unnecessary printf '\"' and incorporate the " instead in
the --date='format-local:"%F %T"' option.
It looks like this was a partial copy-and-paste from GIT_COMMIT_CNT,
but it is unnecessarily complex for GIT_COMMIT_DATE.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reported-by: Idar Tollefsen <itollefs@cisco.com>
|
|
Properly comment this function.
As part of the commenting process several bugs were also fixed:
- when determining the Signal Free Time, ignore messages with
non-OK and non-NACK results, since in those cases nothing was
actually transmitted.
- always show the detected SFTs: this helps verifying that the
measured SFTs are sane. Before they were only shown if there
were failures or warnings, or if --verbose was used.
- the meaning of the first 'sft' array dimension was changed
(effectively inverted), making it a bit easier to explain what
it stood for.
- replace the various pending_tx_rx_*_msgs counters with just one
(pending_tx_rx_msgs). This really shouldn't happen at all, so it
is overkill to split it up by the possible rx results.
- multiple tx_status bits could be set, count them all and don't
stop at the first detected bit.
- add a new check to verify that only the oldest transmit result
was lost in the message queue.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
When exporting buffers from a capture device
to an output device. There are several bugs:
1. The bytesused are set from the exported buffer,
the value might be bigger than the length of the output buffer.
2. The file descriptor field 'm.fd' in 'struct v4l2_buffer' is not set.
This patch fix those issues.
Testing:
modprobe vimc
modprobe vivid
//configure vimc pipeline
media-ctl -d platform:vimc -V '"Sensor A":0[fmt:SBGGR8_1X8/640x480]'
media-ctl -d platform:vimc -V '"Debayer A":0[fmt:SBGGR8_1X8/640x480]'
media-ctl -d platform:vimc -V '"Sensor B":0[fmt:SBGGR8_1X8/640x480]'
media-ctl -d platform:vimc -V '"Debayer B":0[fmt:SBGGR8_1X8/640x480]'
v4l2-ctl -z platform:vimc -d "RGB/YUV Capture" -v width=1920,height=1440
v4l2-ctl -z platform:vimc -d "Raw Capture 0" -v pixelformat=BA81
v4l2-ctl -z platform:vimc -d "Raw Capture 1" -v pixelformat=BA81
// export buffers from vimc capture device (/dev/video2) to vivid output device (/dev/video4)
v4l2-ctl -d2 --stream-mmap --out-device /dev/video4 --stream-out-dmabuf
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
When an operation fails, print an error message
that specify the specific operation that failed
prefixed with the current function name.
This makes debugging less painful.
Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
The warning about a late reply or Feature Abort to a transmitted
message was rather vague. Show whether it is a late reply or a
late Feature Abort and report the opcode in human readable format.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Split off the tuner, record and timer tests into a separate
source since cec-test.cpp became a bit too big.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
The 'Day error: November 31, at 6:00 am, for 1 hr.' test can also use
the send_timer_error helper.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
A single function dealt with tuner, record and timer messages,
split this up into three, one function for each type of message.
The programmed timer handling in the main processing loop is also
split off into its own function.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Start and stop recording as timers are scheduled. Schedule future timers
if a completed timer has a recording sequence. Delete overlapped and
unfinished timers. Reduce available media space when a recording is
completed.
Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Check that Timer Status and Time Cleared Status replies have a valid
operand. Send timers with out-of-range dates and check follower's
response. Send an out-of-range recording sequence and check that the timer
is not set. Send a duplicate timer and check that the timer is not set.
Set overlapping timers and check that the timer overlap warning is set.
In the follower, keep track of timers that have been received and warn
if there may be insufficient space for a programmed recording.
Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
This change was totally wrong. All the existing drivers (except
rc-loopback) return the number of transmitters, not what would be
a valid mask. The documentation also says so.
This reverts commit eb47c00736586329a2043512dacb10fcf95aa58a.
Signed-off-by: Sean Young <sean@mess.org>
|
|
Signed-off-by: Sean Young <sean@mess.org>
|
|
Check that the recording device ignores a Standby message while it is
recording. When the recording is finished, check that the recording device
enters standby unless the recording device is the active source.
Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Expand the One Touch Record tests so that the follower and initiator know
their local and remote device types and respond accordingly. Send Record
TV Screen and check that Record On source replies are valid. Send Record
On source messages and check that Record Status replies are valid. Send
Record Off and check that the recording terminates.
Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
The logging of the signal free time was no longer done when
show == true and verbose == false, fix the logic.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: 8639ff89 ("cec-ctl: report low drive without --verbose")
|
|
Use the same phrase as in the CEC specification.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
The vidtv test requires CONFIG_MEDIA_CONTROLLER_DVB=y, so drop this
from the 'mc' target and if vidtv is explicitly selected as target,
then verify (if possible) that this config option is set.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Also document that vidtv is part of the all and mc targets.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
When analyzing a low-level pin log with (--analyze-pin the low
drive condition was only reported if --verbose was also given.
But this is important enough that it should also be reported without
--verbose.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
The CEC_MSG_ROUTING_INFORMATION handler fell through to the
CEC_MSG_GET_MENU_LANGUAGE handler for no good reason. Just return
instead.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
A device may use a Backup logical address (aka Reserved in CEC
Version < 2.0) if the logical addresses that the device would normally
used are unavailable. Since a Backup logical address is not unique to any
device type, it cannot be used to determine the device type of the
follower. Instead use the more accurate log_addr_type as returned by
CEC_ADAP_G_LOG_ADDRS to find the device type.
Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
Remove the Record Status test for One Touch Record because the follower
sends these kinds of messages in response to Record On.
Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
|
The convention is to have the type ("lirc_mode2/") prefixed so the
BPF loader knows what type it is.
Signed-off-by: Sean Young <sean@mess.org>
|
|
Logical Addresses 12 and 13 were called Reserved 1/2 in CEC 1.4,
but were renamed to Backup 1/2 in CEC 2.0. Follow that new name,
also because the corresponding #defines in cec.h use BACKUP as well.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
|
